ShellCheck is great, but since it works on syntax, it can't catch problems that can only be determined at runtime, like "if myfunc" with set -e on.

Example here: https://news.ycombinator.com/item?id=33122256