>On one hand, the economy is legitimately growing and shares are becoming more valuable

The implication here is that output and productivity is growing. Not that money is becoming less valuable. A more precise term than “valuable” is purchasing power.

Are Americans gaining purchasing power? Not really, because equity gains are being cancelled out by currency losses, if you’re an American that is lucky enough to even own significant equity.